RFR(M): 8204615: [lworld] C2 support for java.lang.Object methods on value types

Roland Westrelin rwestrel at redhat.com
Fri Jul 6 08:51:56 UTC 2018


Hi Tobias,

> Yes, I've tried again and I get all kinds of crashes. I think we could make it work by changing the
> debug info for monitorenter but it's definitely more complex than my webrev.00.

If the method is deoptimized once the the monitor is being locked (by a
concurrent class loading), then we would not want to reexecute the
bytecode. Not sure if we can have a single bytecode where sometimes we
want to reexecute the bytecode, sometimes not.

> Since this is one of the last missing pieces for LW1, I would like to push the patch and enhance it
> later if we find a better way. What do you think?

Sure. The thing I still don't understand is why the bci of the
monitorenter, given it can throw, is not included in the range covered
by the exception handler. Shouldn't it be?

Roland.


More information about the valhalla-dev mailing list