RFR:JDK-8198749 Translation of value constructors in classic constructor notation
srikanth.adayapalam at oracle.com
Wed Jul 11 10:56:00 UTC 2018
Please review the following patch that implements the changes required for
https://bugs.openjdk.java.net/browse/JDK-8198749 ([lworld] Translation
of value constructors in classic constructor notation)
Part of the work in supporting value construction in the classic
will happen independently on behalf of
https://bugs.openjdk.java.net/browse/JDK-8205910(diagnose use of 'this'
with DU fields (for VTs and VBCs)).
Normally I would have requested the review after a fair bit more of
testing and self-review, but given your proposed long absence, I am
requesting the review now. However, I am happy to note that the code is
in pretty decent shape for another person to study (known issues at the
I will continue with the testing and self review in parallel.
If time is an issue, you can limit the review to the following source files:
and these test files: (these give an idea of what works already and
allows you to experiment by tweaking)
(1) make.at() calls may not be updated consistently/uniformly.
(2) I need to double check that some subtree translations are not
(3) Some of the other *older* modified tests need rewriting - they
compare javap output which is flaky due to constant pool offsets
changing anytime there is a change in code generation scheme.
(4) Some code duplication can be avoided by creating utility routines.
langtools tests are green (except for one non-material failure).
More information about the valhalla-dev