RFR(L): 8205044: [lworld] Interpreter and compiler support for acmp with value type operands

Tobias Hartmann tobias.hartmann at oracle.com
Thu Jul 12 07:10:51 UTC 2018


Hi Ioi,

thanks for the review!

Best regards,
Tobias

On 12.07.2018 01:30, Ioi Lam wrote:
> Hi Tobias,
> 
> I looked at the interpreter part of the change. I think it correctly implements the perturbation
> technique as described in [1].
> 
> Thanks
> 
> - Ioi
> 
> [1] http://mail.openjdk.java.net/pipermail/valhalla-dev/2018-January/003722.html
> 
> 
> On 7/10/18 7:01 AM, Tobias Hartmann wrote:
>> Hi,
>>
>> please review the following patch:
>> https://bugs.openjdk.java.net/browse/JDK-8205044
>> http://cr.openjdk.java.net/~thartmann/8205044/webrev.00/
>>
>> I've ported this code from the Exp branch [1]. We therefore still use the klass pointer alignment
>> trick to determine if an oop points to a value type. We can later enhance this to use the mark word.
>>
>> Thanks,
>> Tobias
>>
>> [1]
>> http://mail.openjdk.java.net/pipermail/valhalla-dev/2018-March/003935.html
>> http://mail.openjdk.java.net/pipermail/valhalla-dev/2018-February/003824.html
> 


More information about the valhalla-dev mailing list