RFR JDK-8207194: [lworld] Update InnerClassLambdaMetafactory to add ValueTypes attribute in generated class
mandy.chung at oracle.com
Mon Jul 16 21:01:57 UTC 2018
On 7/16/18 1:16 PM, forax at univ-mlv.fr wrote:
> In Class.getDeclaredValueTypeNames(), at the end, you can returns
> 'names' instead of reloading the field declaredValueTypeNames from the
> memory (which is a volatile read).
> Given that you publish an immutable Set, i believe there is no need to
> declare declaredValueTypeNamesas volatile here, if you remove it, at
> worst, each thread will need to recompute it once, in practice at some
> point the other threads will see the value.
True. I will change this before I push.
> In the InnerClassLambdaFactory, isDeclaredValueType can be private.
> Otherwise, thumb up.
Thanks for the review.
More information about the valhalla-dev