[lworld] Test cases for value type consistency checks

Tobias Hartmann tobias.hartmann at oracle.com
Wed Jul 18 07:32:04 UTC 2018


Hi Ioi,

this looks good to me. Just noticed that there is some uncommented code in ValuePoint.java.

To get some more C2 coverage, it would be good to also run the tests with -Xcomp or (even better)
run the ConsistencyTest::test method multiple times to trigger compilation.

Do some of these tests fail? Because there is a "// BUG" comment in ConsistencyTest.java.

Thanks,
Tobias

On 17.07.2018 08:08, Ioi Lam wrote:
> I have modified Frederic's test cases for the value type consistency checks [1]. See
> 
> http://cr.openjdk.java.net/~iklam/valhalla/tests_for_value_types_consistency_checks.v01/
> 
> The test cases were originally driven by a shell script [2], and I rewrote them to run inside jtreg.
> The idea is to build 2 set of classes that have a different idea of whether "LPoint;" is a VT or
> not, and see how these classes interact.
> 
> I'll try to write more test cases, including ones that use Reflection and MethodHandles.
> 
> Thanks
> - Ioi
> 
> 
> [1] http://hg.openjdk.java.net/valhalla/valhalla/rev/a5573f4f6392
> [2] http://cr.openjdk.java.net/~iklam/valhalla/tests_for_value_types_consistency_checks.v01/run.sh


More information about the valhalla-dev mailing list