RFR JDK-8207815: [lworld] JVM_GetArrayElement and, JVM_SetArrayElement don't work for flatten array

John Rose john.r.rose at oracle.com
Thu Jul 19 00:23:22 UTC 2018


If getComponentType is null you need to throw IAE.

You can do this by sending the non-array straight to the native function:

- if (!componentType.isPrimitive()) {
+ if (componentType != null && !componentType.isPrimitive()) {



On Jul 18, 2018, at 5:16 PM, mandy chung <mandy.chung at oracle.com> wrote:
> 
> Array::get and Array::set call JVM_GetArrayElement and
> JVM_SetArrayElement function to get and set an array element.
> The JVM entry points don't support flattened arrays.
> 
> Instead of adding the flatten array support in JVM_GetArrayElement
> and JVM_SetArrayElement, it's straight-forward to do that in
> Array::get and Array::set in Java.
> 
> Webrev:
> http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8207815/webrev.00/index.html
> 
> Mandy



More information about the valhalla-dev mailing list