[lworld] Patch for TestNewAcmp.java

Tobias Hartmann tobias.hartmann at oracle.com
Fri Jul 20 08:56:33 UTC 2018


Hi Ioi,

thanks for fixing! Pushed.

Best regards,
Tobias

On 19.07.2018 19:05, Ioi Lam wrote:
> TestNewAcmp.javafails when running with a product VM. It's missing -XX:+UnlockDiagnosticVMOptions.
> 
> Here's a patch that fixes it. Since I am not a committer, could someone push it?
> 
> Thanks
> - Ioi
> 
> 
> -------------------
> 
> # HG changeset patch
> # User iklam
> # Date 1531433067 25200
> #      Thu Jul 12 15:04:27 2018 -0700
> # Branch lworld
> # Node ID 2cb813013879c1ee0de27d1e928a0feaa61e16e3
> # Parent  208e3da0bbc560095361f435d2a1c31d9c7510ae
> Summary: Added missing -XX:+UnlockDiagnosticVMOptions to TestNewAcmp.java
> 
> diff -r 208e3da0bbc5 -r 2cb813013879 test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNewAcmp.java
> --- a/test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNewAcmp.java Thu Jul 12 14:57:10 2018 -0700
> +++ b/test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNewAcmp.java Thu Jul 12 15:04:27 2018 -0700
> @@ -27,27 +27,27 @@
>   * @library /testlibrary /test/lib /compiler/whitebox /
>   * @compile -XDenableValueTypes -XDallowFlattenabilityModifiers TestNewAcmp.java
>   * @run driver ClassFileInstaller sun.hotspot.WhiteBox
> - * @run main/othervm -Xbootclasspath/a:. -XX:+WhiteBoxAPI -Xbatch
> + * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbatch
>   *                   -XX:+EnableValhalla -XX:TypeProfileLevel=222
>   * -XX:CompileCommand=dontinline,compiler.valhalla.valuetypes.TestNewAcmp::test*
>   * compiler.valhalla.valuetypes.TestNewAcmp 0
> - * @run main/othervm -Xbootclasspath/a:. -XX:+WhiteBoxAPI -Xbatch
> + * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbatch
>   *                   -XX:+EnableValhalla -XX:TypeProfileLevel=222 -XX:+AlwaysIncrementalInline
>   * -XX:CompileCommand=dontinline,compiler.valhalla.valuetypes.TestNewAcmp::test*
>   * compiler.valhalla.valuetypes.TestNewAcmp 0
> - * @run main/othervm -Xbootclasspath/a:. -XX:+WhiteBoxAPI -Xbatch
> + * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbatch
>   *                   -XX:+EnableValhalla -XX:TypeProfileLevel=222
>   * -XX:CompileCommand=dontinline,compiler.valhalla.valuetypes.TestNewAcmp::test*
>   * compiler.valhalla.valuetypes.TestNewAcmp 1
> - * @run main/othervm -Xbootclasspath/a:. -XX:+WhiteBoxAPI -Xbatch
> + * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbatch
>   *                   -XX:+EnableValhalla -XX:TypeProfileLevel=222 -XX:+AlwaysIncrementalInline
>   * -XX:CompileCommand=dontinline,compiler.valhalla.valuetypes.TestNewAcmp::test*
>   * compiler.valhalla.valuetypes.TestNewAcmp 1
> - * @run main/othervm -Xbootclasspath/a:. -XX:+WhiteBoxAPI -Xbatch
> + * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbatch
>   *                   -XX:+EnableValhalla -XX:TypeProfileLevel=222
>   * -XX:CompileCommand=dontinline,compiler.valhalla.valuetypes.TestNewAcmp::test*
>   * compiler.valhalla.valuetypes.TestNewAcmp 2
> - * @run main/othervm -Xbootclasspath/a:. -XX:+WhiteBoxAPI -Xbatch
> + * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbatch
>   *                   -XX:+EnableValhalla -XX:TypeProfileLevel=222 -XX:+AlwaysIncrementalInline
>   * -XX:CompileCommand=dontinline,compiler.valhalla.valuetypes.TestNewAcmp::test*
>   * compiler.valhalla.valuetypes.TestNewAcmp 2
> 


More information about the valhalla-dev mailing list