[Nestmates] RFR (S): Support access to VM annotations from nonfindable classes

Mandy Chung mandy.chung at oracle.com
Fri Nov 2 15:38:21 UTC 2018


Thanks for the link and webrev.  The module access was also one thing
I considered how to get access to these VM annotation.  This may
worth revisiting when we gather more use cases where user code
requires access to these annotation.

Mandy

On 11/1/18 1:13 AM, Vladimir Ivanov wrote:
> FTR some time ago I tried a different approach based on access checks 
> provided by the module system [1]. It covers broader scope in a 
> uniform manner, but also more involved and doesn't fit well existing 
> class loading machinery [2].
>
> Best regards,
> Vladimir Ivanov
>
> [1] 
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-February/025976.html
>
> [2] It does proper access checks very late in the class loading 
> process optimistically assuming all annotations are accessible and 
> initiate reparsing if any of used ones aren't accessible to the class 
> being loaded.
>
> On 31/10/2018 14:18, Lois Foltan wrote:
>> Please review the following change as part of the ongoing prototyping 
>> work to support MethodHandle Lookup functionality to define a 
>> nestmate class.  In particular this fix allows access to VM 
>> annotations for nonfindable classes.
>>
>> webrev: 
>> http://cr.openjdk.java.net/~lfoltan/wrk_nestLookupDefineClass_annotations.1/webrev/ 
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8171335
>>
>> Thanks,
>> Lois



More information about the valhalla-dev mailing list