RFR(M): 8206141: [lworld] Improve accessing a flattened value type array passed as Object[]

Tobias Hartmann tobias.hartmann at oracle.com
Fri Oct 5 12:19:50 UTC 2018


Hi Roland,

thanks for updating the webrev. Looks good to me!

On 05.10.2018 10:49, Roland Westrelin wrote:
> The null check in the runtime call would require deoptimizing from the
> runtime call which in turns means stack walking is functional and so
> calling the runtime call goes through a stub to setup last sp, right?

Right, I'm fine with leaving the check in compiled code.

> Also, going forward, if the value element has no reference fields we
> might want to use the clone intrinsic here too which would require the
> null check to be inlined in the compiled code anyway.

Yes, that makes sense.

Best regards,
Tobias


More information about the valhalla-dev mailing list