[Nestmates] RFR (S): Dynamic nestmate update
lois.foltan at oracle.com
Mon Oct 29 20:01:40 UTC 2018
On 10/29/2018 2:37 AM, David Holmes wrote:
> webrev: http://cr.openjdk.java.net/~dholmes/dynamic-nestmates/webrev/
> This fleshes out Mandy's initial implementation with additional error
> checking on the VM side to match the defineClass API, and with an
> additional VM test.
I have a couple of concerns about this approach longer term for setting
the nest host post return from either
SystemDictionary::resolve_from_stream or SystemDictionary::parse_stream
- for a findable class as soon as that class is added to the
SystemDictionary, is there any concern that another thread could request
that class and access it before its nest host is legitimately set?
Would it be better to pass nest host down into ClassFileParser so it is
known at the point the InstanceKlass is created?
- At the time class file nest members attributes are parsed and the nest
host setting within the byte stream matches the nest host used when
jvm_lookup_define_class() is invoked, than in my opinion an error should
- Finally, should the setting of nest_host be known at the point class
file load hook is processed?
More information about the valhalla-dev