[Nestmates] RFR (S): Support access to VM annotations from nonfindable classes
lois.foltan at oracle.com
Wed Oct 31 23:10:12 UTC 2018
On 10/31/2018 6:11 PM, David Holmes wrote:
> Hi Lois,
> On 1/11/2018 7:18 AM, Lois Foltan wrote:
>> Please review the following change as part of the ongoing prototyping
>> work to support MethodHandle Lookup functionality to define a
>> nestmate class. In particular this fix allows access to VM
>> annotations for nonfindable classes.
> So all that effort to pass through one boolean just so it can
> eventually be used in one place:
> 2095 const bool privileged =
> loader_data->is_the_null_class_loader_data() ||
> 2096 loader_data->is_platform_class_loader_data() ||
> 2097 loader_data->is_shortlived() ||
> 2098 can_access_vm_annotations;
> ? We definitely need to find a better way to transmit this contextual
> information. :)
> Otherwise looks fine.
Thank you for the review.
> Are you likely to push this evening? Otherwise I will push my change
> and then you'll have the awkward merge to do.
You can go forward and push, I will do the merge afterwards.
>> bug: https://bugs.openjdk.java.net/browse/JDK-8171335
More information about the valhalla-dev