RFR 8219242 [lworld] C1 aastore on a Phi node needs flattened array check

Tobias Hartmann tobias.hartmann at oracle.com
Thu Feb 21 10:05:59 UTC 2019


Hi Ioi,

On 21.02.19 05:17, Ioi Lam wrote:
> http://cr.openjdk.java.net/~iklam/valhalla/8219242-aastore-phi-node-needs-flat-check.v02/
> 
> Note that I changed this line
> 
> 1687   bool obj_store = x->elt_type() == T_OBJECT; assert(x->elt_type() != T_ARRAY, "never used");
> 
> because x->elt_type() is determine by the bytecode (Xastore) and no bytecode will set it to T_ARRAY.

Looks good but please move the assert into a new line before pushing.

Best regards,
Tobias


More information about the valhalla-dev mailing list