RFR(M): 8222221: [lworld] Valhalla causes performance slowdown for reflective invocations

Roland Westrelin rwestrel at redhat.com
Tue Jul 2 13:51:23 UTC 2019


> http://cr.openjdk.java.net/~thartmann/8222221/webrev.00/

Why drop stuff related to Compile::_type_hwm?

Why no check for is_not_flat() for the first generate_valueArray_guard
below?  Shouldn't the is_not_flat() test be in
generate_valueArray_guard()?

4042       Node* is_flat = generate_valueArray_guard(klass_node, NULL);
4043       if (!original_t->is_not_flat()) {
4044         generate_valueArray_guard(original_kls, bailout);
4045       }

In Parse::array_store(), why remove:

|| elemptr->is_valuetypeptr()

?

253         Node *kls = load_object_klass(ary);
254         Node *layout_val = load_lh_array_tag(kls);

Isn't the usual coding convention Node* kls?

Roland.


More information about the valhalla-dev mailing list