Flat Array null check issue - Re: RFR(L) Valhalla support for AArch64 v.05

Dmitry Samersoff dms at samersoff.net
Tue Jul 9 13:36:08 UTC 2019


Hi Roland,

Alias tends to strip attachments, so sending it directly.

I checked x86 code. On x86 we don't mask loaded class in x86_64.ad file,
on AArch64 I do it right in aarch64.ad

I can follow x86 convention but it means that we need carefully insert
masking to all place where it necessary.

Should we consider to put masking inside LoadNKlass and LoadKlass
and use LoadN/LoadP when we need unmasked value?

Thank you,
-Dmitry


On 09.07.19 14:26, Roland Westrelin wrote:
> 
> Hi Dmitry,
> 
>>> Is the sequence above the actual code generated by c2? It would then
>>> seem that we test for the property bit on the already masked klass
>>> pointer.
>>
>> Yes. It's the code generated by C2 and I agree with you finding.
> 
> Can you send the output of PrintIdeal for that method?
> 
> Thanks,
> Roland.
> 


More information about the valhalla-dev mailing list