Flat Array null check issue - Re: RFR(L) Valhalla support for AArch64 v.05

Roland Westrelin rwestrel at redhat.com
Wed Jul 10 09:26:59 UTC 2019


Hi Dmitry,

>> I will take a closer look at that issue. Do you reproduce it with:
>> 
>> http://cr.openjdk.java.net/~dsamersoff/valhalla_lworld_aarch64/webrev.05/
>
> Thank you!
>
> Yes, you can reproduce it with this webrev.
>
> Also, I think you can reproduce the issue on x86 by adding
>
>  andl($dst$$Register, oopDesc::compressed_klass_mask());
>
> to instruct loadNKlass(rRegN dst, memory mem)
> inside x86_64.ad

Masking is handled by platform independent code in C2. x86 used to take
care of the masking in the ad file but it no longer does. Why doesn't
aarch64 follow the x86 implementation?

Roland.


More information about the valhalla-dev mailing list