RFR: 8224861: Rework restrictions introduced by 8223029 for nullable arrays
tobias.hartmann at oracle.com
Wed May 29 07:40:13 UTC 2019
Okay, that looks like a GC crash that I've seen before in the CI. I've filed:
I think your change is good to go.
On 29.05.19 09:26, Tobias Hartmann wrote:
> Hi Roland,
> I've executed some tests with webrev.01 and I'm hitting this intermittent issue when running
> TestNullableArrays with "-XX:+EnableValhalla -XX:+UseParallelGC -XX:+UseParallelOldGC -XX:+UseNUMA
> # Internal Error
> pid=5508, tid=3335
> # assert(!is_null(v)) failed: narrow klass value can never be zero
> On 28.05.19 16:59, Tobias Hartmann wrote:
>> Hi Roland,
>> this looks good to me and is much cleaner now.
>> Some minor comments:
>> - In macroArrayCopy.cpp, you can move the 'array_klass' declarations in the else branches or even
>> into the assert statements-
>> - The indentation in TestNullableArrays.java:514 is wrong.
>> - In type.cpp, please add comments to line 2370 and 3459 explaining that we don't set 'exact'
>> because the runtime type might be [V due to [V <: [V?
>> No new webrev required.
>> On 28.05.19 15:22, Roland Westrelin wrote:
>>> New webrev:
>>> A couple conditions were not quite right in the previous one.
More information about the valhalla-dev