RFR: JDK-8211027 jdb "eval" should perform substitutability test when applying == to inline types

David Simms david.simms at oracle.com
Tue Oct 15 08:53:24 UTC 2019


Look good, with two minor comments:

  * Spelling "isSubtituable()" => "isSubstitutable()"
  * An alternative is to use ValueBootstrapMethods.isSubstitutable()
    rather than re-implement ?

Cheers

/Mr. Simms



On 11/10/19 10:21 PM, Frederic Parain wrote:
> Please review this change in JDI to implement the substitutability test
> when jdb “eval” applies the ‘==‘ operator to inline types.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8211027
>
> Webrev:
> http://cr.openjdk.java.net/~fparain/jdi_substitutability/webrev.00/index.html
>
> Regards,
>
> Fred
>



More information about the valhalla-dev mailing list