RFR: https://bugs.openjdk.java.net/browse/JDK-8232785

Frederic Parain frederic.parain at oracle.com
Wed Oct 23 12:18:26 UTC 2019


Mandy,

Thank you for the review.

Fred


> On Oct 22, 2019, at 15:11, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> Looks okay to me.
> 
> Mandy
> 
> On 10/22/19 5:40 AM, Frederic Parain wrote:
>> Greetings,
>> 
>> Please review this patch adding unit tests for inline types
>> support in jdb. The goal is to have high level unit tests
>> to track regressions at the debugger level. More refined
>> unit tests for each layer (JDI, JDWP, JVMTI, JNI) will be
>> added later once their respective specifications have been
>> updated with inline types support.
>> 
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8232785
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~fparain/jdb_tests/webrev.00/index.html
>> 
>> Note: the patch also contains a 1 line fix in primitive array detection.
>> 
>> Thank you,
>> 
>> Fred
>> 
> 



More information about the valhalla-dev mailing list