Review Request: 8238358: Implementation of JEP 371: Hidden Classes

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Mon Apr 6 19:08:46 UTC 2020


On 4/6/20 11:54, Mandy Chung wrote:
> On 4/6/20 9:56 AM, serguei.spitsyn at oracle.com wrote:
>>
>> The suggested fix is:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/valhalla-jdi-regression-8242166.1/
>>
>
> This patch looks okay. I'll include in my local patch.
>
> On 4/6/20 11:00 AM, Chris Plummer wrote:
>>
>> I think that's fine but I don't think it should be done in the 
>> context of this Vahalla webrev since it has nothing to do with 
>> Vahalla. I'd suggest filing an RFE and pushing it to jdk/jdk. Easier 
>> to track that way if there are issues down the road.
>>
>
> I am okay to follow up as a separate RFE.

Filed RFE:
   https://bugs.openjdk.java.net/browse/JDK-8242241
     add assert to ClassUnloadEventImpl::className

Thanks,
Serguei

>
> thanks
> Mandy



More information about the valhalla-dev mailing list