Review Request: 8238358: Implementation of JEP 371: Hidden Classes
mandy.chung at oracle.com
Sat Apr 18 21:09:57 UTC 2020
On 4/18/20 12:47 AM, Chris Plummer wrote:
>> It's a link to
>> This is how the current JVM TI spec defines.
> Since it looks like this reference was present before your changes, I
> guess it's ok to leave it, but like JDWP maybe a bug should be filed
> to clean it up.
Right, they are existing reference. I'll let Serguei to file a JBS
issue to follow up.
> Regarding your JNI spec reference, it say "The JNI uses the Java VM’s
> representation of type signatures" and then has a table called "Java
> VM Type Signatures". No where in the JNI spec do you see "JNI
> Signature" or "JNI Type Signature". It seems we should always just use
> "Type Signature"?
I agree that the svc specs should be examined and use the terminologies
> Even the JVMTI spec is not consistent. It has a couple of references
> to JNI Type Signature as links to the JNI spec, but also says "type
> signatures" in a couple of places, including for
> GetLocalVariableTable() which refers the the JVMS: "The local
> variable's type signature, encoded as a modified UTF-8 string. The
> signature format is the same as that defined in The Java™ Virtual
> Machine Specification, Chapter 4.3.2. "
More information about the valhalla-dev