[lworld] RFR: allow inline classes to have abstract supers

Harold Seigel hseigel at openjdk.java.net
Mon Apr 20 20:31:34 UTC 2020


On Mon, 20 Apr 2020 20:08:58 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Plesae review this change to allow inline classes to have super classes that are abstract classes.  This fix does not
>> test that the abstract classes are 'special'.  That will be done in a future release.
>> Also, fix verification issue with assigning an inline type to an object of one of its super classes.
>> 
>> Tests will be added once javac support for inline types having abstract classes is merged in.
>> 
>> Thanks, Harold
>
> Looks good to me.
> Have you already created the follow-up CR to implement the support for inline friendly abstract classes?
> Do you have an idea if changes lines 179-181 of verificationTypes.cpp will trigger more class loading then today? If
> yes, could this become an issue?
> Fred

Hi Fred,

Thanks for reviewing this change.

I have not created the new CR, but will shortly.

The changes to lines 179-181 should not trigger more class loading than
today.  Whenever the verifier needs to check if type A is assignable to
type B, it has to load both types, unless they are the same, or type B
is java.lang.Object or an interface. However, this load would not be
needed if the only valid super class for an inline type was
java.lang.Object.

Thanks, Harold

On 4/20/2020 4:09 PM, Frederic Parain wrote:
>
> *@fparain* approved this pull request.
>
> Looks good to me.
> Have you already created the follow-up CR to implement the support for
> inline friendly abstract classes?
> Do you have an idea if changes lines 179-181 of verificationTypes.cpp
> will trigger more class loading then today? If yes, could this become
> an issue?
>
> Fred
>
>> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/valhalla/pull/24#pullrequestreview-396775095>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AOXZ7OTVTZ3PJYMI6LTD2ILRNSTWVANCNFSM4MMWWNRA>.
>

-------------

PR: https://git.openjdk.java.net/valhalla/pull/24


More information about the valhalla-dev mailing list