[lworld] RFR: 8243627: [lworld] Co-evolve jdk-valhalla tests along with JDK-8237072

Mandy Chung mchung at openjdk.java.net
Mon Apr 27 23:21:43 UTC 2020


On Mon, 27 Apr 2020 04:17:49 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

> Mandy,
> 
> May I request you to review these changes to jdk-valhalla tests ?
> 
> JDK-8237072 adds supports for the new syntax notation of V.ref and V.val to
> refer to the reference projection of a value type V and its value projection.
> The old syntax of V? is withdrawn. This change also has class file implications
> where the descriptor/signature encodings will now start mentioning $ref in the
> class pool entries. Also every inline type results in two class files now
> one for each projection - with the reference projection class being the superclass
> of the inline class.
> 
> I'll push them after your review and *after* JDK-8237072 itself is pushed.
> Thanks in advance.

Looks good to me.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/27


More information about the valhalla-dev mailing list