[lworld] RFR: 8251046: [lworld] [lw3] C1 should avoid heap allocations in withfield when possible [v2]

Frederic Parain fparain at openjdk.java.net
Mon Aug 10 15:01:50 UTC 2020


On Thu, 6 Aug 2020 14:09:26 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Frederic Parain has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Refactor larva update methods
>>  - Fixes from review feedback
>
> Overall looks good to me, nice improvement! I've added some comments to the code.

Hi Tobias!
Thank you for your feedback.
Code formatting has been fixed.
Adding virtual calls to the Value class forced to add null checks everywhere, so instead, updates of the inline type
larvae are now performed in methods of the GraphBuilder class, encapsulating the null check.

Regards,

Fred

-------------

PR: https://git.openjdk.java.net/valhalla/pull/137


More information about the valhalla-dev mailing list