for review: 8236522: "always atomic" modifier for inline classes to enforce atomicity

John Rose john.r.rose at
Wed Jan 22 20:52:37 UTC 2020

On Jan 15, 2020, at 6:03 AM, Frederic Parain <frederic.parain at> wrote:
> instanceKlass.hpp:442
>  In addition to the setter, a getter should be provided for the
>  new _is_naturally_atomic bit, this would prevent the implementation
>  details to leak to valueKlass.hpp:211

OK, I’ll do that.  I didn’t place the getter on instanceKlass because
the question only makes sense for inline types, not identity types.

Maybe I should make the setter and getter protected on instanceKlass,
and promote the getter to public in valueKlass?  Or is it fine to make
everything public on instanceKlass?

— John

More information about the valhalla-dev mailing list