[lworld] RFR: 8248163: jdb crashes when invoking "lock" command on inline class

Harold Seigel hseigel at openjdk.java.net
Thu Jul 2 14:57:45 UTC 2020


On Thu, 2 Jul 2020 13:16:38 GMT, Frederic Parain <fparain at openjdk.org> wrote:

> Please review this patch which fix an issue with the JVMTI method GetObjectMonitorUsage() and inline types.
> The behavior of the method when called on an inline type instance is to return a valid result and not throwing an
> exception. The result will always show that the monitor is not locked and has never been locked.
> 
> A unit test has been added to cover this case.
> 
> Thank you,
> 
> Fred

Hi Fred,
It looks good.  Could you add a comment above line 964 in jmvtiEnvBase.cpp about inline types and is_always_locked()
returning true? Also, the copyrights for the tests shouldn't say "2020, 2020".

I don't need to see another version.
Thanks, Harold

-------------

Marked as reviewed by hseigel (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/104


More information about the valhalla-dev mailing list