[lworld] RFR: 8248163: jdb crashes when invoking "lock" command on inline class [v2]

Frederic Parain fparain at openjdk.java.net
Thu Jul 2 16:10:19 UTC 2020


On Thu, 2 Jul 2020 14:55:29 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment and fix copyright headers
>
> Hi Fred,
> It looks good.  Could you add a comment above line 964 in jmvtiEnvBase.cpp about inline types and is_always_locked()
> returning true? Also, the copyrights for the tests shouldn't say "2020, 2020".
> 
> I don't need to see another version.
> Thanks, Harold

Harold,

Thank you for your review.
I've added a comment and fixed the copyright years format.

Regards,

Fred

-------------

PR: https://git.openjdk.java.net/valhalla/pull/104


More information about the valhalla-dev mailing list