[lworld] RFR: 8242402: multianewarray is missing checks on the bottom class

Harold Seigel hseigel at openjdk.java.net
Mon Jul 6 20:14:45 UTC 2020


On Mon, 6 Jul 2020 20:09:59 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> src/hotspot/share/classfile/systemDictionary.cpp line 365:
>> 
>>> 364:             THROW_NULL(vmSymbols::java_lang_IncompatibleClassChangeError());
>>> 365:           }
>>> 366:       k = k->array_klass(ndims, CHECK_NULL);
>> 
>> Is it worthwhile using THROW_MSG_NULL to provide a helpful message with the exception?
>
> Something like this?
> 
> `THROW_MSG_NULL(vmSymbols::java_lang_IncompatibleClassChangeError(), "L/Q mismatch on bottom type");`
> 
> Fred

Yes. That looks good.  Thanks.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/105


More information about the valhalla-dev mailing list