[lworld] RFR: 8249396: JNI function IsSameObject should apply the substitutability test for inline types

Harold Seigel hseigel at openjdk.java.net
Wed Jul 15 13:19:06 UTC 2020


On Tue, 14 Jul 2020 21:41:04 GMT, Frederic Parain <fparain at openjdk.org> wrote:

> Please review this patch which fix the implementation of the JNI function IsSameObject by performing a substitutability
> test when two references to inline type instances are passed in argument.
> Passed tests tiers 1 to 3 with Mach5.
> 
> Thank you,
> 
> Fred

Hi Fred,
The changes look good.  Could you add a comment that the code in JNIHandles::is_same_object() is similar to
InterpreterRuntime::is_substitutable()? Thanks, Harold

-------------

Marked as reviewed by hseigel (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/108


More information about the valhalla-dev mailing list