[lworld] RFR: 8250664: [lworld] Rename 'value type' to 'inline type' [v2]

Harold Seigel hseigel at openjdk.java.net
Tue Jul 28 13:44:57 UTC 2020

On Tue, 28 Jul 2020 10:41:14 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Renamed all inline type specific occurrences of "value" to "inline" in JIT code and tests.
>> I did not rename:
>> - Variable names "vt" (for value type) and "vk" (for value klass) because alternative naming "it" and "ik" is already
>>   used for iterators and instance klasses.
>> - "MyValue" inline class names in the tests because these are user defined "values".
> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>   Some more renaming and whitespace fixes

Hi Tobias,
This exhaustive change looks good.  I have three minor comments that can be addressed before or after pushing this
change, or ignored.  I don't need to see a new webrev.

1.  In sharedRuntime_x86_64.cpp, change 'value' to 'inline' in line 890.

2. In nmethod.cpp, change these from "Value Entry" to "Inline Entry"?
n += maybe_print_entry_label(stream, block_begin, inline_entry_point(),             "[Value Entry Point]");
n += maybe_print_entry_label(stream, block_begin, verified_entry_point(),           "[Verified Entry Point]");
 n += maybe_print_entry_label(stream, block_begin, verified_inline_entry_point(),    "[Verified Value Entry Point]");
n += maybe_print_entry_label(stream, block_begin, verified_inline_ro_entry_point(), "[Verified Value Entry Point

3. (Very minor nit)  some of the tests say "a inline type" instead of "an inline type".

Thanks for doing this!


Marked as reviewed by hseigel (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/121

More information about the valhalla-dev mailing list