[lworld] RFR: rename valhalla runtime tests to 'inline' [v2]

Harold Seigel hseigel at openjdk.java.net
Thu Jul 30 13:23:50 UTC 2020


On Wed, 29 Jul 2020 18:29:40 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove -XDemitQtypes and -XDenableValueTypes and other small changes
>
> Just a few minor comments.
> CircularityTest.java and EmptyInlineTest.java appear as deleted/new instead of renamed, I don't know why.
> Otherwise, looks good to me.
> 
> Thank you,
> 
> Fred

Hi Fred,
Thanks for the review.  I made the changes that you suggested.  I also don't know why CircularityTest.java and
EmptyInlineTest.java appear as deleted/new instead of renamed,  It happened after I replaced the tabs with spaces.

Harold

> test/hotspot/jtreg/runtime/valhalla/inlinetypes/UninitializedInlineFieldsTest.java line 31:
> 
>> 30:  * @library /test/lib
>> 31:  * @compile -XDemitQtypes -XDenableValueTypes -XDallowWithFieldOperator -XDallowFlattenabilityModifiers Point.java
>> JumboInline.java UninitializedInlineFieldsTest.java 32:  * @run main/othervm -Xint -XX:InlineFieldMaxFlatSize=64
>> runtime.valhalla.inlinetypes.UninitializedInlineFieldsTest
> 
> Do we still need -XDemitQtypes and -XDenableValueTypes options?

The -XDemitQtypes and -XDenableValueTypes options are no longer needed.  I removed them from all the runtime valhalla
tests.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/122


More information about the valhalla-dev mailing list