[lworld] [Rev 02] RFR: 8247357: Flattenable field concept needs some cleanup

Frederic Parain fparain at openjdk.java.net
Fri Jun 12 21:03:15 UTC 2020


On Fri, 12 Jun 2020 20:22:11 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Frederic Parain has updated the pull request with a new target base due to a merge or a rebase. The pull request now
>> contains eight commits:
>>  - Merge remote-tracking branch 'upstream/lworld' into flattenable_squashed2
>>  - Renaming in comments
>>  - Merge remote-tracking branch 'upstream/lworld' into flattenable_squashed2
>>  - Renaming again (allocated_inline -> inlined)
>>  - Merge remote-tracking branch 'upstream/lworld' into flattenable_squashed2
>>  - More renaming
>>  - Merge remote-tracking branch 'upstream/lworld' into flattenable_squashed2
>>  - Remove flattenable concept and associated code
>
> Hi Fred,
> The changes look good.  One minor misspelling in templateTable_x86.cpp, "fiel" instead of "field".
> Also, should JVM_ACC_FIELD_INLINED be 4000 instead of 8000?
> Thanks, Harold

Harold,

Thank you for reviewing this. I've fixed the typo and changed back the value of JVM_ACC_FIELD_INLINED (it doesn't make
a difference right now, but there's no reason to change it).

Fred

-------------

PR: https://git.openjdk.java.net/valhalla/pull/77


More information about the valhalla-dev mailing list