[lworld] RFR: 8248330: [lworld] [lw3] test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetImplementedInterfaces/getintrf007/TestDescription.java fails because of IdentityObject

Frederic Parain frederic.parain at oracle.com
Thu Jun 25 17:33:39 UTC 2020


Thank you Mandy, I’ll revert the temporary fix.

Fred


> On Jun 25, 2020, at 13:21, Mandy Chung <mchung at openjdk.java.net> wrote:
> 
> On Thu, 25 Jun 2020 16:56:54 GMT, Frederic Parain <fparain at openjdk.org> wrote:
> 
>>> The changes look good.  Does this also fix the test failures listed in JDK-8247491?
>> 
>> Harold,
>> 
>> Thank you for the review.
>> 
>> I've tested the fix with the tests listed in JDK-8247491:
>> vmTestbase/nsk/jdi/ClassType/allInterfaces/allinterfaces001/TestDescription.java
>> vmTestbase/nsk/jdi/ClassType/interfaces/interfaces001/TestDescription.java
>> vmTestbase/nsk/jdi/InterfaceType/implementors/implementors001/TestDescription.java
>> vmTestbase/nsk/jdi/InterfaceType/subinterfaces/subinterfaces001/TestDescription.java
>> vmTestbase/nsk/jdi/InterfaceType/superinterfaces/superinterfaces001/TestDescription.java
>> vmTestbase/nsk/jvmti/ClassPrepare/classprep001/TestDescription.java
>> 
>> They all pass now.
>> 
>> Fred
> 
> Hi Fred,
> 
> With GetImplementationInterfaces filtering `java.lang.IdentityObject`, the temporary fix [1] should be reverted.
> Otherwise looks good.
> 
> Mandy
> [1] https://github.com/openjdk/valhalla/commit/806fff417e2adc296428ec4e7b41fff6cdfe1e15
> 
> -------------
> 
> PR: https://git.openjdk.java.net/valhalla/pull/100



More information about the valhalla-dev mailing list