Review Request: Add ClassOption.STRONG and default is unspecified

Remi Forax forax at univ-mlv.fr
Wed Mar 18 08:29:52 UTC 2020


As a non native English reader, i prefer the word "adjacent".

otherwise, looks good.

Rémi

----- Mail original -----
> De: "John Rose" <john.r.rose at oracle.com>
> À: "mandy chung" <mandy.chung at oracle.com>
> Cc: "Alex Buckley" <alex.buckley at oracle.com>, "valhalla-dev" <valhalla-dev at openjdk.java.net>
> Envoyé: Mercredi 18 Mars 2020 01:23:51
> Objet: Re: Review Request: Add ClassOption.STRONG and default is unspecified

> On Mar 17, 2020, at 1:41 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>> 
>> The javadoc is updated per offline discussion with Alex.
>>    http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/weak-strong-class/
>> 
>> I pushed this version to the sandbox to get the new ClassOption::STRONG in.  We
>> can continue to improve the javadoc per any feedback.
> 
> At a glance, it looks nice.  Love the $64 word “coterminous”.
> Good advice about when to use strong vs. non-strong.


More information about the valhalla-dev mailing list