[lworld] [Rev 01] RFR: 8244414: [lworld] Migrate Valhalla micro benchmarks suite to not use V? syntax

Srikanth Adayapalam sadayapalam at openjdk.java.net
Wed May 6 14:41:58 UTC 2020


On Wed, 6 May 2020 13:58:42 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Srikanth Adayapalam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix garbled test per review comment.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 4003:
> 
>> 4002:
>> 4003:         boolean haveValues = false;
>> 4004:         boolean haveRefs = false;
> 
> If the goal is to fix the behavior of conditional expression typing, I think the fix should happen outside lub(), more
> specifically in Attr::condType

Hmm. - to me it looks more natural to push this down to the service. But I am open to bubbling this up to the client.
With your consent, I will combine this with the fix for JDK-8244513

-------------

PR: https://git.openjdk.java.net/valhalla/pull/35


More information about the valhalla-dev mailing list