[Integrated] [lworld] RFR: 8244414: [lworld] Migrate Valhalla micro benchmarks suite to not use V? syntax
sadayapalam at openjdk.java.net
Wed May 6 16:29:29 UTC 2020
On Wed, 6 May 2020 13:26:31 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:
> Description of changes:
> Hi Maruizio,
> Could you please review these assorted changes that block the build of Valhalla micro
> benchmarks ? This is a culumative fix for JDK-8244414 and JDK-8244458
> You could skip a review of the benchmark source files themselves - these have only mechanical changes from V? to V.ref
> except for one case where there was a usage of Node?<K,V> with Node actually being an identity class. We don't support
> the transformed Node.ref<K,V> for identity classes, so I had to drop the '?'
> Problems fixed:
> (i) Resolve.java: Diamond inference did not work for inline type constructors: Basically, the (static factory method
> equivalent) constructors synthesized during diamond inference did not have their reference projection counterparts and
> had to be paired up with them.
> (ii) Types.java: LUB computation in the presence of mixed values and non-values should first apply widening conversion.
> (iii) Enter.java: When we recompile files due to annotation processing rounds, discard
> any prior state carried on by the reference projection so as to keep it in sync with its peer.
> (A separate test will be added separately - for now building microbenchmarks is the test for this)
This pull request has now been integrated.
Author: Srikanth Adayapalam <sadayapalam at openjdk.org>
Stats: 313 lines in 36 files changed: 0 ins; 135 del; 178 mod
8244414: [lworld] Migrate Valhalla micro benchmarks suite to not use V? syntax
More information about the valhalla-dev