[lworld] RFR: JDK-8243204 add class load time checking of abstract super classes of…

Harold Seigel hseigel at openjdk.java.net
Fri May 8 15:04:43 UTC 2020


On Thu, 7 May 2020 15:36:58 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Shouldn't `ClassFileParser::check_super_of_inline_type()` also check that no super classes implement the
>> `java.lang.IdentityObject` interface?
>
> The update to the pull request implements John's "bit A and bit B" idea posted in the java-valhalla slack channel.
> Instead of A and B, the flags are named invalid_inline_super and invalid_identity_super.  In this pull request,
> invalid_identity_super exists but is never set nor read.  That is for a future change.  Flag invalid_inline_super is
> set to TRUE in a class's InstanceKlass, if, at class load time, the class is determined to be an invalid super class
> for an inline type.  Checking that the class's constructor is abstract will be done at a future date once there is
> compiler support.

Today's updated change improves the comment for function is_invalid_super_for_inline_type() and makes it a static
function.  Also, it moves the InstanceKlass invalid_inline_super and invalid_identity_super flags into misc_flags.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/34


More information about the valhalla-dev mailing list