[lworld] RFR: 8244711: [lworld] Javac needs to tweak checks for interface implementation by an inline type.

Jim Laskey github.com+63007666+JimLaskey at openjdk.java.net
Mon May 11 12:08:46 UTC 2020


On Mon, 11 May 2020 11:13:53 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

> When javac needs to check if a class implements a particular interface, it should
> check if the reference projection of the class is a subtype of the interface. (Rather
> than checking if the concerned class is a subtype of the interface)

Since asSuper is always called with a true checkReferenceProjection, why not drop the argument and rename as
asSuperWithProjection (or some such). If you introduce a need later for the false case then you can just call asSuper
directly. I.E., argument seems redundant.

test/langtools/tools/javac/valhalla/lworld-values/AutoCloseableTest.java line 57:

> 56:     }
> 57: }

Missing last newline.

test/langtools/tools/javac/valhalla/lworld-values/ConflictingSuperInterfaceTest.java line 15:

> 14:     }
> 15: }

Missing last newline.

test/langtools/tools/javac/valhalla/lworld-values/ConflictingSuperInterfaceTest.java line 1:

> 1: /*
> 2:  * @test /nodynamiccopyright/

Missing Copyright.

-------------

Changes requested by JimLaskey at github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/valhalla/pull/41


More information about the valhalla-dev mailing list