[lworld] [Rev 01] RFR: 8244810: [lworld] Decommission arrayStorageProperties from Klass:array_klass() et el

David Simms dsimms at openjdk.java.net
Thu May 14 06:46:37 UTC 2020


On Wed, 13 May 2020 16:10:44 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> David Simms has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Copyright syntax
>
> src/hotspot/share/oops/arrayStorageProperties.hpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
>> 3:  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> 
> (Comment for the whole file)
> I understand this is the first stage of a set of complex changes to remove the `ArrayStorageProperties` code, but
> cleaning up the `ArrayStorageProperties` as things are getting removed might help to see progress (and would make
> reviews easier). For instance:
>   - `clear_flattened()`
>   - `set_flattened()`
>   - `set_null_free()`
>   - `for_signature(Symbol* sig)`
> seem to not be used anymore and could be removed.

Correct, ultimately the whole thing can go...but yes, they can go now.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/44


More information about the valhalla-dev mailing list