[lworld] [Rev 02] RFR: 8242612: [lworld] Javac should not expressly encode the new super interface types in class files

Srikanth Adayapalam sadayapalam at openjdk.java.net
Mon May 18 15:47:09 UTC 2020


> Jim, Could you please review this change ? TIA.
> 
> Changes:
> 
>     - Withdraw the new top type InlineObject (per design)
>     - Do not encode the new top types in class files as this is noisy and
>       very disruptive and let the static compiler and the dynamic environments
>       inject these types as needed. (since classes compiled with legacy compilers
>       will not encode these top types anyway the VM has to resort to injection,
>       why not resort to injection for everything is the motivation)
>     - Adjust some code that is surprised by super interfaces being empty.
> 
> More background is available in https://bugs.openjdk.java.net/browse/JDK-8242612

Srikanth Adayapalam has updated the pull request incrementally with two additional commits since the last revision:

 - Fix white space issue
 - Test changes for JDK-8242612, reverting changes made for explicit encoding of top types

This pull request has now been integrated.

Changeset: 9a5e8f39
Author:    Srikanth Adayapalam <sadayapalam at openjdk.org>
URL:       https://git.openjdk.java.net/valhalla/commit/9a5e8f39
Stats:     279 lines in 75 files changed: 151 ins; 21 del; 107 mod

8242612: lworld] Javac should not expressly encode the new super interface types in class files
8237954: [lworld] @ignored tests need to be tweaked and reenabled.

Reviewed-by: jlaskey

-------------

Changes:
  - all: https://git.openjdk.java.net/valhalla/pull/50/files
  - new: https://git.openjdk.java.net/valhalla/pull/50/files/ecb41ea4..70002a64

Webrevs:
 - full: https://webrevs.openjdk.java.net/valhalla/50/webrev.02
 - incr: https://webrevs.openjdk.java.net/valhalla/50/webrev.01-02

  Stats: 152 lines in 63 files changed: 9 ins; 52 del; 91 mod
  Patch: https://git.openjdk.java.net/valhalla/pull/50.diff
  Fetch: git fetch https://git.openjdk.java.net/valhalla pull/50/head:pull/50

PR: https://git.openjdk.java.net/valhalla/pull/50


More information about the valhalla-dev mailing list