[lworld] [Rev 02] RFR: 8245216: [lworld] The JVM should inject the IdentityObject interface to types which need it
hseigel at openjdk.java.net
Wed May 20 17:39:58 UTC 2020
On Wed, 20 May 2020 15:36:37 GMT, Frederic Parain <fparain at openjdk.org> wrote:
>> Please review these changes for JDK-8245216.
>> This code makes the JVM to inject the IdentityObject interface when needed.
>> The details are in the CR:
>> Thank you,
> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
> Cleanup, bug fixes, work around for 8245487
Changes look good, other than the nit about the comment in verificationType.cpp.
Thanks for doing this.
src/hotspot/share/classfile/verificationType.cpp line 66:
> 65: return !from_is_array ||
> 66: this_class == SystemDictionary::Cloneable_klass() ||
> 67: this_class == SystemDictionary::Serializable_klass() ||
Can you update the comment at line 63 to include java.lang.IdentityObject?
Marked as reviewed by hseigel (Committer).
More information about the valhalla-dev