[lworld] RFR: 8255522: [lworld] References to biased pattern remain in markWord::is_unlocked()

Sergey Kuksenko skuksenko at openjdk.java.net
Tue Nov 3 06:06:09 UTC 2020


On Wed, 28 Oct 2020 14:56:20 GMT, David Simms <dsimms at openjdk.org> wrote:

> * more gtest mark word tests
> * assert any use of "biased locking" (there are some existing "has_biased_pattern()" asserts not guarded "UseBiasedLocking")
> * remove biased_lock_mask_in_place from is_unlocked

It looks good for me.
With very minor notes.
Now biased_lock_pattern and inline_type_pattern are equals.The comment that EnableValhalla and UseBiasedLocking can't be set to true both is located higher in the markWord.hpp text. Maybe it's make sense to repeat it near that constants? To make it more clear.

How frequently "markWord::print_on" is used? Should we add printing "inline type" markword info?

-------------

Marked as reviewed by skuksenko (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/245


More information about the valhalla-dev mailing list