RFR: 8254275: [valhalla/jep390] Revise "value-based class" & apply to wrappers [v4]

Dan Smith dlsmith at openjdk.java.net
Thu Nov 5 00:27:07 UTC 2020


On Mon, 2 Nov 2020 19:43:12 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Dan Smith has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressing additional review comments for ValueBased.html
>
> src/java.base/share/classes/java/lang/doc-files/ValueBased.html line 42:
> 
>> 40:     <li>the class declares implementations of <code>equals</code>,
>> 41:         <code>hashCode</code>, and <code>toString</code> which are computed
>> 42:         solely from the values of the class's instance fields (and properties of
> 
> Can the word "properties" be avoided,m here and above? It it a loaded term.  Perhaps attributes?

"members" would be the idiomatic Java word, I suppose

-------------

PR: https://git.openjdk.java.net/valhalla/pull/222


More information about the valhalla-dev mailing list