RFR: 8252182: [JEP 390] Diagnose synchronization on @ValueBased classes

Frederic Parain fparain at openjdk.java.net
Mon Nov 23 13:32:13 UTC 2020


On Fri, 20 Nov 2020 20:50:58 GMT, Lois Foltan <lfoltan at openjdk.org> wrote:

> Please review the following changes to add JVM support for @ValueBased class annotation.

Looks good to me.
Just one comment: The ValueBased annotation is ignored for non-privileged classes, this would prevent users from testing their own code with the DiagnoseSyncOnValueBasedClasses flag. Is there a particular reason to not enforce the ValueBased annotation on user code?

Fred

-------------

Marked as reviewed by fparain (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/274


More information about the valhalla-dev mailing list