RFR: 8252182: [JEP 390] Diagnose synchronization on @ValueBased classes

Harold Seigel hseigel at openjdk.java.net
Mon Nov 23 13:54:08 UTC 2020


On Fri, 20 Nov 2020 20:50:58 GMT, Lois Foltan <lfoltan at openjdk.org> wrote:

> Please review the following changes to add JVM support for @ValueBased class annotation.

The changes look good!  Can the check for "DiagnoseSyncOnPrimitveWrappers != 0" be removed from lines 330 and 442?  I don't think "obj->klass()->is_value_based()" will be TRUE unless "DiagnoseSyncOnPrimitiveWrappers != 0".

Perhaps do an assert instead?

-------------

PR: https://git.openjdk.java.net/valhalla/pull/274


More information about the valhalla-dev mailing list