RFR: 8252182: [JEP 390] Diagnose synchronization on @ValueBased classes

Frederic Parain FREDERIC.PARAIN at ORACLE.COM
Mon Nov 23 19:09:22 UTC 2020


Thank you for the explanation.

Fred


> On Nov 23, 2020, at 1:55 PM, Roger Riggs <rriggs at openjdk.java.net> wrote:
> 
> On Mon, 23 Nov 2020 13:29:33 GMT, Frederic Parain <fparain at openjdk.org> wrote:
> 
>> Looks good to me.
>> Just one comment: The ValueBased annotation is ignored for non-privileged classes, this would prevent users from testing their own code with the DiagnoseSyncOnValueBasedClasses flag. Is there a particular reason to not enforce the ValueBased annotation on user code?
>> 
>> Fred
> 
> The jdk.internal.ValueBased annotation is internal to the base module and only defined for use by the JDK implementation as per JEP 390. It is intended to indicate that an application or library is using a system class instance incorrectly.
> 
> -------------
> 
> PR: https://git.openjdk.java.net/valhalla/pull/274



More information about the valhalla-dev mailing list