RFR: 8252182: [JEP 390] Diagnose synchronization on @ValueBased classes [v3]

Lois Foltan lfoltan at openjdk.java.net
Mon Nov 23 22:49:09 UTC 2020


On Mon, 23 Nov 2020 22:45:25 GMT, Lois Foltan <lfoltan at openjdk.org> wrote:

>>> Looks good to me.
>>> Just one comment: The ValueBased annotation is ignored for non-privileged classes, this would prevent users from testing their own code with the DiagnoseSyncOnValueBasedClasses flag. Is there a particular reason to not enforce the ValueBased annotation on user code?
>>> 
>>> Fred
>> 
>> The jdk.internal.ValueBased annotation is internal to the base module and only defined for use by the JDK implementation as per JEP 390. It is intended to indicate that an application or library is using a system class instance incorrectly.
>
> Thank you Harold, I have made your suggested changes to runtime/synchronizer.cpp

Thank you Fred for the review.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/274


More information about the valhalla-dev mailing list