[lworld] RFR: 8253592: [lworld] C2: Additional fixes for handling empty inline types [v2]

Tobias Hartmann thartmann at openjdk.java.net
Thu Sep 24 12:48:14 UTC 2020


> While working on JDK-8253416, I found more issues with handling of empty inline types in C2:
> - Compile::build_start_state assumes that all inline type arguments are scalarized if has_scalarized_args() is true but
>   one of the arguments could be non-scalarized (for example, if it's an empty inline type).
> - Loads/stores from/to inline type fields should be removed. Refactoring the related code also fixes an issue where alias
>   analysis gets confused when looking at flattened fields of empty inline types.
> 
> Unrelated fixes:
> - Handling of unexpected inline/non-inline klasses in _new/_defaultvalue.
> - Missing @DontCompile statements in some tests

Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:

  Disabling some tests until JDK-8253416 is fixed

-------------

Changes:
  - all: https://git.openjdk.java.net/valhalla/pull/197/files
  - new: https://git.openjdk.java.net/valhalla/pull/197/files/ea4d32d4..4c32cea6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=valhalla&pr=197&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=valhalla&pr=197&range=00-01

  Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/valhalla/pull/197.diff
  Fetch: git fetch https://git.openjdk.java.net/valhalla pull/197/head:pull/197

PR: https://git.openjdk.java.net/valhalla/pull/197


More information about the valhalla-dev mailing list