[lworld] RFR: 8253416: [lworld] C1: incorrect nestmate access to flattened field if nest-host is not loaded

Frederic Parain fparain at openjdk.java.net
Fri Sep 25 14:20:17 UTC 2020


On Fri, 25 Sep 2020 13:27:48 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Tobias,
>> 
>> Thank you for the explanation on the needs_patching flag and the Withfield node.
>> So, did you keep the needs_patching argument in the copy_inline_content()  method only for verification purpose?
>> 
>> Overall, changes look good to me.
>> 
>> Fred
>
>> So, did you keep the needs_patching argument in the copy_inline_content() method only for verification purpose?
> 
> Yes, but we could also move the assert into the caller. What do you prefer?

I'm fine with both approaches (assert in the caller or in copy_inline_content()), just pick the solution you think is
the safer (I don't think it makes a lot of difference from a performance point of view).

Fred

-------------

PR: https://git.openjdk.java.net/valhalla/pull/198


More information about the valhalla-dev mailing list