[lworld] RFR: 8265184: [lworld] [AArch64] Broken fast class init barrier for static calls in c2i adapter
thartmann at openjdk.java.net
Wed Apr 14 12:00:16 UTC 2021
On Wed, 14 Apr 2021 08:44:34 GMT, Nick Gasson <ngasson at openjdk.org> wrote:
> The tier1 test runtime/clinit/ClassInitBarrier.java fails on the lworld
> branch on AArch64. The particular case that fails is calling a static
> native method `A.staticN()` which should block in the c2i adapter until
> class A's initialisation is complete but doesn't.
> The check for a static method is backwards: the class initialisation
> barrier code is executed when the method is *not* static (ANDS will set
> the EQ flag if the result is zero). I'm not sure why it's like this but
> fast class initialisation for AArch64 was added after the original
> lworld port which also touches generate_i2c2i_adapters so maybe
> something got messed up in the merge.
> Fix by making the code the same as mainline.
Looks good to me! I think the fix for [JDK-8230962](https://bugs.openjdk.java.net/browse/JDK-8230962) broke this.
Marked as reviewed by thartmann (Committer).
More information about the valhalla-dev