[lworld] RFR: 8266086: [lworld][lw3] C1 produces incorrect code when GlobalValueNumbering is used [v2]

Tobias Hartmann thartmann at openjdk.java.net
Thu Apr 29 14:23:10 UTC 2021


On Thu, 29 Apr 2021 14:14:33 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Please review this fix in C1 GlobalValueNumbering.
>> The problem is that C1 doesn't track that a flattened field has been updated when it writes the individual values of this flattened field. The proposed fix is to record the enclosing flattened field with the StoreField node of each individual field, and use this information when the GlobalValueNumbering processes those nodes to kill the flattened field in the ValueMap.
>> 
>> Tested locally (Linux 64) with hotspot_valhalla (including new unit test) and jdk_valhalla test suites.
>> 
>> Thank you,
>> 
>> Fred
>
> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixes after initial review

Thanks for updating, looks good to me!

Best regards,
Tobias

-------------

Marked as reviewed by thartmann (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/395


More information about the valhalla-dev mailing list